[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[mgp-users 1503] MagicPoint segfaults on x86_64: patch to fix it



Hi there,

it seems that a number of people have been seeing segfaults
of MagicPoint, segfaults which I have only seen when compiling
on an x86_64 platform, eg

https://bugs.launchpad.net/ubuntu/+source/mgp/+bug/63976

I think I have just found a fix for that problem and enclose
a patch below.

I also wanted to point out that you still do not appear to have
added my "feature" patch from 2009 judging from the current
snapshots, so I thought I would "nudge" you on that too (ha-ha!)

In [mgp-users 1501] Re: MagicPoint patch

you said:

> OK. Then, I will merge your code after simple check.
> Thanks,
> --
> Yoshifumi Nishida
> nishida@sfc.wide.ad.jp

All the best and thanks again for MagicPoint.

-- 
Kevin M. Buckley                                  Room:  CO327
School of Engineering and                         Phone: +64 4 463 5971
 Computer Science
Victoria University of Wellington
New Zealand

$ diff -u draw.c{.orig,}
--- draw.c.orig 2010-05-02 17:06:50.000000000 +1200
+++ draw.c      2010-05-02 17:07:02.000000000 +1200
@@ -5471,12 +5471,12 @@
                    XFT_FAMILY, XftTypeString, font,
                    XFT_ENCODING, XftTypeString, registry,
                    XFT_STYLE, XftTypeString, style,
-                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, 0);
+                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, NULL);
        } else {
                xftfont = XftFontOpen(display, screen,
                    XFT_FAMILY, XftTypeString, font,
                    XFT_ENCODING, XftTypeString, registry,
-                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, 0);
+                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, NULL);
        }
        if (xftfont == 0) {
                free(xfont);