[mgp-users 1504] Re: MagicPoint segfaults on x86_64: patch to fix it

[Yoshifumi Nishida <nishida@sfc.wide.ad.jp>]

Hello Kevin,

Thank you so much for the fix. I merged this into the code.
Also, I'm terribly sorry for merging your patch you sent me before.
It is now integrated and it will appear the next snapshot version.

Sorry for my slow response and thanks for your contribution.
If I forgot to merge anything from anyone, please point it out.
--
Yoshifumi Nishida
nishida@sfc.wide.ad.jp

From: Kevin.Buckley@ecs.vuw.ac.nz
Subject: [mgp-users 1503] MagicPoint segfaults on x86_64: patch to fix it
Date: Sun, 2 May 2010 17:24:36 +1200
Message-ID: <>

 > Hi there,
 > 
 > it seems that a number of people have been seeing segfaults
 > of MagicPoint, segfaults which I have only seen when compiling
 > on an x86_64 platform, eg
 > 
 > https://bugs.launchpad.net/ubuntu/+source/mgp/+bug/63976
 > 
 > I think I have just found a fix for that problem and enclose
 > a patch below.
 > 
 > I also wanted to point out that you still do not appear to have
 > added my "feature" patch from 2009 judging from the current
 > snapshots, so I thought I would "nudge" you on that too (ha-ha!)
 > 
 > In [mgp-users 1501] Re: MagicPoint patch
 > 
 > you said:
 > 
 > > OK. Then, I will merge your code after simple check.
 > > Thanks,
 > > --
 > > Yoshifumi Nishida
 > > nishida@sfc.wide.ad.jp
 > 
 > All the best and thanks again for MagicPoint.
 > 
 > -- 
 > Kevin M. Buckley                                  Room:  CO327
 > School of Engineering and                         Phone: +64 4 463 5971
 >  Computer Science
 > Victoria University of Wellington
 > New Zealand
 > 
 > $ diff -u draw.c{.orig,}
 > --- draw.c.orig 2010-05-02 17:06:50.000000000 +1200
 > +++ draw.c      2010-05-02 17:07:02.000000000 +1200
 > @@ -5471,12 +5471,12 @@
 >                     XFT_FAMILY, XftTypeString, font,
 >                     XFT_ENCODING, XftTypeString, registry,
 >                     XFT_STYLE, XftTypeString, style,
 > -                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, 0);
 > +                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, NULL);
 >         } else {
 >                 xftfont = XftFontOpen(display, screen,
 >                     XFT_FAMILY, XftTypeString, font,
 >                     XFT_ENCODING, XftTypeString, registry,
 > -                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, 0);
 > +                   XFT_PIXEL_SIZE, XftTypeDouble, (float)csize, NULL);
 >         }
 >         if (xftfont == 0) {
 >                 free(xfont);
 >