(mgp-users 00084) patch to mgp-snap-981214.tar.gz

[Carlos Puchol <cpg@rocketmail.com>]

hi, i did not have a lot of time to try and understand
the code in mgp to pursue luigi's suggestions.

but i decided to go ahead and go through the code
in mgp "-Wall clean", i.e. clean it up a little
so that no warnings show up when compiling with -Wall.
it was not a whole lot of work, luckily. to me, that
is an indication that the code in there is good.

this fixed a couple of really minor potential bugs
(a pointer might be dereferenced when not initialized).
hopefully, i did not introduce any. (most of the work was
in the image/ directory, which, i take it, is going to
be kept around and it not following outside development?)

the patch is at:

	http://puchol.com/cpg/mgp/mgp-patch-981228.gz

it is 17kb.

i ony have a couple of warnings i don't know how to handle.
suggestions appreciated!

image/copyright.h:23: warning: `Copyright' defined but not used


draw.c: In function `epstoimage':
draw.c:3237: warning: variable `fd' might be clobbered by `longjmp' or `vfork'
draw.c:3241: warning: variable `pid' might be clobbered by `longjmp' or `vfork'
draw.c:3235: warning: argument `xzoom' might be clobbered by `longjmp' or
`vfork'
draw.c:3235: warning: argument `yzoom' might be clobbered by `longjmp' or
`vfork'

image/new.c:55: warning: decimal constant is so large that it is unsigned
image/new.c:56: warning: decimal constant is so large that it is unsigned

could i suggest to add /opt/freetype*
as a possible place to look for freetype in configure.
/opt is a very popular place for people to put stuff
these days.

finally, i have only tried these changes on linux.
things may be slightly different in other environments.

-- carlos
_________________________________________________________
DO YOU YAHOO!?
Get your free @yahoo.com address at http://mail.yahoo.com